Sim-recon-1.1.0 Release Notes

From GlueXWiki
Revision as of 15:00, 3 June 2015 by Marki (Talk | contribs)

(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to: navigation, search

This version is based on revision 18205 of ^trunk/sim-recon.

At JLab, it was built using version_1.4.xml.

Package Version
jana 0.7.2
sim-recon 1.1.0
hdds 3.1
cernlib 2005
xerces-c 3.1.1
root 5.34.26
ccdb 1.05
evio 4.3.1

Changes since the last release:


r17571 | staylor | 2015-03-10 16:34:39 -0400 (Tue, 10 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc
  M /trunk/sim-recon/src/libraries/PID/DParticleID.h

Add method to predict which FCAL block should fire given a track.


r17594 | staylor | 2015-03-11 17:16:44 -0400 (Wed, 11 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DReferenceTrajectory.cc

Fix uninitialized value error flagged by valgrind


r17595 | staylor | 2015-03-11 17:33:28 -0400 (Wed, 11 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceHDDM.cc

make sure has_TDC and has_fADC are initialized for the start counter for tag=null case


r17598 | pmatt | 2015-03-11 17:55:26 -0400 (Wed, 11 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.cc
  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.h

Hit/matching efficiency of TOF/FCAL/SC as a function of projected-hit-detector-element.



r17599 | staylor | 2015-03-11 18:39:11 -0400 (Wed, 11 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TOF/DTOFGeometry.h

Fix code to avoid uninitialized variable errors found by valgrind


r17604 | staylor | 2015-03-12 10:58:35 -0400 (Thu, 12 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DGeometry.cc

Add sdir and tdir directions for cdc wires (the actual wire direction is given by udir; the other two define an orthonormal coordinate system).


r17607 | pmatt | 2015-03-12 14:12:06 -0400 (Thu, 12 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.cc
  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.h
  M /trunk/sim-recon/src/libraries/PID/DDetectorMatches.h
  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc
  M /trunk/sim-recon/src/libraries/PID/DParticleID.h

Restored Simon's old DC dE/dx mean/sigma functions. Made histograms of delta-dE/dx and delta-beta.



r17637 | jrsteven | 2015-03-13 10:05:00 -0400 (Fri, 13 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/SConscript
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DCustomAction_p2pi_hists.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DCustomAction_p2pi_hists.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DCustomAction_p2pi_taggerCoincidence.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DCustomAction_p2pi_taggerCoincidence.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DEventProcessor_p2pi_hists.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DEventProcessor_p2pi_hists.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DFactoryGenerator_p2pi_hists.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DReaction_factory_p2pi_hists.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DReaction_factory_p2pi_hists.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/SConscript
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DCustomAction_Pi0Cuts.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DCustomAction_Pi0Cuts.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DCustomAction_p3pi_hists.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DCustomAction_p3pi_hists.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DCustomAction_p3pi_taggerCoincidence.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DCustomAction_p3pi_taggerCoincidence.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DEventProcessor_p3pi_hists.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DEventProcessor_p3pi_hists.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DFactoryGenerator_p3pi_hists.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DReaction_factory_p3pi_hists.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DReaction_factory_p3pi_hists.h
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/SConscript

initial checkin of 2pi and 3pi plugins for monitoring


r17645 | jrsteven | 2015-03-13 15:01:43 -0400 (Fri, 13 Mar 2015) | 2 lines Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DCustomAction_p2pi_hists.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_kshort2pi.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_pmiss.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DCustomAction_p3pi_hists.cc
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/DReaction_factory_p3pi_hists.cc
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_pmiss_2FCAL.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_pmiss_FCAL-BCAL.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_preco_2FCAL.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_preco_FCAL-BCAL.C

add macros for p2pi and p3pi plugins


r17648 | jrsteven | 2015-03-13 15:47:41 -0400 (Fri, 13 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/DCustomAction_p2pi_hists.cc
  D /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco1.C (from /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco.C:17645)
  A /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco2.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_pmiss_2FCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_pmiss_FCAL-BCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_preco_2FCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_preco_FCAL-BCAL.C

update histogram names and macros


r17649 | jrsteven | 2015-03-13 15:49:39 -0400 (Fri, 13 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackFitterKalmanSIMD.h

temporarily revert to hard-coded FDC resolution parameter to restore reasonable tracking FOM


r17652 | jrsteven | 2015-03-13 17:17:15 -0400 (Fri, 13 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco2.C

remove colz for 1D plot option


r17654 | jrsteven | 2015-03-13 17:52:51 -0400 (Fri, 13 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_kshort2pi.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_pmiss.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco1.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco2.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_pmiss_2FCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_pmiss_FCAL-BCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_preco_2FCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_preco_FCAL-BCAL.C

cosmetic changes to figures


r17655 | staylor | 2015-03-13 18:25:12 -0400 (Fri, 13 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DParticleID.h

Add prototype for method to predict BCAL wedge given track -- code itself not implemented yet.


r17656 | staylor | 2015-03-13 18:28:29 -0400 (Fri, 13 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc

Remove reference to RootGeom -- hard-code gas and scintillator properties for now. It looks like using TGeoManager is dangerous and appears to lead to strange behaviour (hanging or crashing) on exit. Implement skeleton for PredictBCALWedge (doesn't do anything yet).


r17668 | davidl | 2015-03-16 14:00:47 -0400 (Mon, 16 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FCAL/DFCALCluster.h

Add GetNHits() method. This avoids having to copy the entire my_hits vector just to find out how many hits there are in the cluster. This was being done in the FCAL_online plugin in a couple of places.


r17679 | pmatt | 2015-03-16 18:48:59 -0400 (Mon, 16 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc

Undo the hard-coding of the gas properties in the last commit. The problem is elsewhere ... to be elaborated on soon.



r17680 | pmatt | 2015-03-16 19:00:04 -0400 (Mon, 16 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DGeometry.cc
  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DRootGeom.cc

There were many places where functions were returned-from early (e.g. something invalid), but the locks were not released first. Release the locks.



r17681 | pmatt | 2015-03-16 19:31:28 -0400 (Mon, 16 Mar 2015) | 33 lines Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/hd_root/hd_root.cc

Call abort() just before program exit. This is a kludge that avoids the double-free and bad-linked-list crashes when freeing memory on program exit (typically in ROOT's TGeoManager and/or TGeoVoxelFinder). Calling abort() prevents the program from deleting the invalid data on exit, since abort() is a hard exit. The memory is still retrieved by the operating system for other processes when the program exits. Nathan and I tracked down the cause of these crashes, but a fix is not yet ready. This kludge is necessary until then (and should be removed afterwards).

Now, these crashes are (seemingly) caused by something in the TTAB library, presumably the file-scope static stl containers (I've had problems with these before in ANALYSIS/DEventWriterROOT.cc). This problem does not always exhibit itself ... the following are the conditions necessary to consistently reproduce the crashes:


Minimal execution necessary to crash with hdds-commissioning/sim-recon(trunk or commissioning)/online-plugins/online-plugin-SBMS revs >= 17133: hd_root /cache/mss/halld/RunPeriod-2014-10/rawdata/Run001516/hd_rawdata_001516_000.evio -PPLUGINS=FCAL_online,monitoring_hists -PEVENTS_TO_KEEP=1 //However, delete the DAQ & TTab libraries from the online plugin SBMS/sbms.py AddDANA function and it's fine (these shouldn't be needed). //For rev 17133, the online plugin SBMS/sbms.py plugin was modified to add DAQ and TTab (along with a few other changes) //Why these plugins? They each access the geometry.

Minimal code necessary to crash a single sim-recon plugin with (above revs) >= 16998 (E.g. delete everything in monitoring_hists except):

brun(): DApplication *dapp = dynamic_cast< DApplication* >( locEventLoop->GetJApplication() ); dapp->GetDGeometry( runnumber );

evnt(): vector<const DParticleID*> locParticleIDs; locEventLoop->Get(locParticleIDs); //in the DParticleID constructor, it's the RootGeom->FindMat("CDchamberGas") (and similar) calls that cause problems.

Minimal execution necessary to crash with above revs >= 16998 & with hacked monitoring_hists (above): hd_root /cache/mss/halld/RunPeriod-2014-10/rawdata/Run001516/hd_rawdata_001516_000.evio -PPLUGINS=monitoring_hists -PEVENTS_TO_KEEP=1 //Delete TTab from sim-recon SBMS/sbms.py AddDANA (AFTER building everything else: for the monitoring_hists build ONLY!) and it's fine


Prior to (above revs) = 16998, the above are fine. At rev 16998, the dynamically-loaded-at-runtime DAQ and TTAB libraries were moved from the programs/Utilities/plugins folder to be statically-linked in DANA-proper (libraries folder).

As mentioned earlier, this suggests that there are problems with the TTAB global variables being cleaned up on program exit. I recommend giving the static stl variables function-scope instead of file-scope ... this fixed similar problems I was seeing with them in DEventWriterROOT.

Until then, this kludge stands. The C++ gods will surely smite us (me?) for this ...



r17684 | staylor | 2015-03-17 05:19:50 -0400 (Tue, 17 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TTAB/DTranslationTable.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTranslationTable.h

Move ROCID_MAP_FILENAME string into the DTranslationTable object. In the previous version this string was at the file scope level in the .cc file. This leads to an invalid read and an invalid free below main upon exit according to a comparison of valgrind output with the only change being where the string is defined.


r17685 | staylor | 2015-03-17 05:21:57 -0400 (Tue, 17 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc

Implement PredictBCALWedge


r17686 | staylor | 2015-03-17 05:38:43 -0400 (Tue, 17 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc

Use floor instead of round when guessing bcal sector.


r17689 | pmatt | 2015-03-17 10:11:26 -0400 (Tue, 17 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.cc
  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.h

Add histograms for matching to projected BCAL hit position/module. Organize histograms in file.



r17692 | pmatt | 2015-03-17 11:18:41 -0400 (Tue, 17 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_BCALReconstruction_p2.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_FCALReconstruction_p2.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_SCReconstruction_p1.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_TOFReconstruction_p1.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Tracking_p3.C

Update some of the macros for changes to the histograms in the ANALYSIS library. More changes needed still.



r17696 | pmatt | 2015-03-17 11:35:54 -0400 (Tue, 17 Mar 2015) | 4 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTranslationTable.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTranslationTable.h
  M /trunk/sim-recon/src/programs/Analysis/hd_root/hd_root.cc

Make global static variables in DTranslationTable have function scope instead. Return these by reference from these container functions, and access only by these functions. This fixes the crash-at-end-of-program problem (double-free, corrupted-memory) mentioned in the rev 17681 hd_root commit. Remove abort() call from hd_root.



r17697 | pmatt | 2015-03-17 14:18:52 -0400 (Tue, 17 Mar 2015) | 3 lines Changed paths:

  A /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_BCAL.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_FCAL.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_SC.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_TOF.C

Breakup matching histograms into different macros for each system.



r17698 | pmatt | 2015-03-17 14:19:50 -0400 (Tue, 17 Mar 2015) | 3 lines Changed paths:

  D /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_p1.C
  D /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_p2.C

Remove old matching macros.



r17699 | pmatt | 2015-03-17 14:23:28 -0400 (Tue, 17 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/SConscript

Add Rootspy to sconscript.



r17700 | jrsteven | 2015-03-17 15:34:23 -0400 (Tue, 17 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_kshort2pi.C

adjust binning in kshort macro


r17718 | pmatt | 2015-03-18 15:22:15 -0400 (Wed, 18 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DKinFitter.cc

Reset the fit data after the event data: in case matrices are grabbed and then freed in the next reset.



r17724 | wmcginle | 2015-03-19 10:13:55 -0400 (Thu, 19 Mar 2015) | 1 line Changed paths:

  A /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim
  A /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim/.Linux_CentOS6-x86_64-gcc4.4.6
  A /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim/.sconsign.dblite
  A /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim/JEventProcessor_pi0bcalskim.cc
  A /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim/JEventProcessor_pi0bcalskim.h
  A /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim/SConscript

adding pi0bcalskim plugin


r17725 | wmcginle | 2015-03-19 10:23:58 -0400 (Thu, 19 Mar 2015) | 1 line Changed paths:

  D /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim/.Linux_CentOS6-x86_64-gcc4.4.6
  D /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim/.sconsign.dblite

removing unnecessary hidden files


r17726 | wmcginle | 2015-03-19 10:30:29 -0400 (Thu, 19 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/SConscript
adding pi0bcalskim plugin name to the SConscript file in directory above itself 

r17747 | davidl | 2015-03-21 10:44:06 -0400 (Sat, 21 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/DAQ/JEventSource_EVIO.cc
  D /trunk/sim-recon/src/libraries/DAQ/cdcalgo16.cc
  D /trunk/sim-recon/src/libraries/DAQ/cdcalgo16.h
  A /trunk/sim-recon/src/libraries/DAQ/fa125algo.cc
  A /trunk/sim-recon/src/libraries/DAQ/fa125algo.h

Implement Naomi's latest timing algorithm


r17748 | davidl | 2015-03-21 10:45:28 -0400 (Sat, 21 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/DAQ/DAQ_init.cc
  M /trunk/sim-recon/src/libraries/DAQ/DCAEN1290TDCConfig.h
  M /trunk/sim-recon/src/libraries/DAQ/DCAEN1290TDCHit.h
  M /trunk/sim-recon/src/libraries/DAQ/DCODAEventInfo.h
  M /trunk/sim-recon/src/libraries/DAQ/DCODAROCInfo.h
  M /trunk/sim-recon/src/libraries/DAQ/DDAQAddress.h
  M /trunk/sim-recon/src/libraries/DAQ/DDAQConfig.h
  M /trunk/sim-recon/src/libraries/DAQ/DEPICSvalue.h
  M /trunk/sim-recon/src/libraries/DAQ/DF1TDCConfig.h
  M /trunk/sim-recon/src/libraries/DAQ/DF1TDCHit.h
  M /trunk/sim-recon/src/libraries/DAQ/DF1TDCTriggerTime.h
  M /trunk/sim-recon/src/libraries/DAQ/DModuleType.h
  M /trunk/sim-recon/src/libraries/DAQ/Df125Config.h
  M /trunk/sim-recon/src/libraries/DAQ/Df125PulseIntegral.h
  M /trunk/sim-recon/src/libraries/DAQ/Df125PulsePedestal.h
  M /trunk/sim-recon/src/libraries/DAQ/Df125PulseRawData.h
  M /trunk/sim-recon/src/libraries/DAQ/Df125PulseTime.h
  M /trunk/sim-recon/src/libraries/DAQ/Df125TriggerTime.h
  M /trunk/sim-recon/src/libraries/DAQ/Df125WindowRawData.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250Config.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250PulseIntegral.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250PulsePedestal.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250PulseRawData.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250PulseTime.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250StreamingRawData.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250TriggerTime.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250WindowRawData.h
  M /trunk/sim-recon/src/libraries/DAQ/Df250WindowSum.h
  M /trunk/sim-recon/src/libraries/DAQ/HDEVIO.cc
  M /trunk/sim-recon/src/libraries/DAQ/HDEVIO.h
  M /trunk/sim-recon/src/libraries/DAQ/JEventSourceGenerator_EVIO.cc
  M /trunk/sim-recon/src/libraries/DAQ/JEventSourceGenerator_EVIO.h
  M /trunk/sim-recon/src/libraries/DAQ/JEventSource_EVIO.h
  M /trunk/sim-recon/src/libraries/DAQ/JFactoryGenerator_DAQ.h
  M /trunk/sim-recon/src/libraries/DAQ/daq_param_type.h

Add svn:keywords property to most files in DAQ library


r17749 | davidl | 2015-03-21 10:50:56 -0400 (Sat, 21 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/DAQ/fa125algo.cc

Fixed comparison of signed and unsigned int.


r17773 | jrsteven | 2015-03-23 22:51:59 -0400 (Mon, 23 Mar 2015) | 8 lines Changed paths:

  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DGeometry.cc
  M /trunk/sim-recon/src/programs/Simulation/HDGeant/calibDB.cc

1) Update DGeometry to look for LH2 target instead of CH2 target to resolve the following errors seen in recent simulations.

src/JANA/JGeometryXML.cc:241 Node or attribute not found for xpath "//section[@name='Target']/tubs[@name='CH2T']/@Rio_Z". src/JANA/JGeometryXML.cc:241 Node or attribute not found for xpath "//composition[@name='targetVessel']/posXYZ[@volume='CH2T']/@X_Y_Z".

2) Update HDGeant/calibDB.cc to pull solenoid field map from CCDB based on run number (similar to what is done for hd_root/hd_ana). Any solenoid field setting provided in the control.in file should override what is in the CCDB.



r17778 | kmoriya | 2015-03-24 10:21:42 -0400 (Tue, 24 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_pmiss_2FCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_pmiss_FCAL-BCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_preco_2FCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p3pi_hists/HistMacro_p3pi_preco_FCAL-BCAL.C

avoid crash in case top level directory does not exist


r17779 | kmoriya | 2015-03-24 10:21:59 -0400 (Tue, 24 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_kshort2pi.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_pmiss.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco1.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/p2pi_hists/HistMacro_p2pi_preco2.C

avoid crash in case top level directory does not exist


r17786 | jrsteven | 2015-03-24 11:49:10 -0400 (Tue, 24 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/BCAL/DBCALGeometry.cc

fix off-by-one problem in BCAL sector counting. Now the center of module 1 is at phi=0 as expected


r17789 | staylor | 2015-03-24 14:20:33 -0400 (Tue, 24 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCHit.h
  M /trunk/sim-recon/src/libraries/FDC/DFDCHit_factory.cc

Add pulse_height to DFDCHit for use in DFDCPseudo and extract pulse peak (pulse height) from pulse pedestal object


r17790 | staylor | 2015-03-24 14:21:36 -0400 (Tue, 24 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceHDDM.cc

Fill pulse_height fields recently added to DFDCHit object.


r17791 | staylor | 2015-03-24 14:23:54 -0400 (Tue, 24 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCGeometry.h

Define STRIP_ZERO_OFFSET for use in determining strip position.


r17793 | staylor | 2015-03-24 14:49:46 -0400 (Tue, 24 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DGeometry.cc

Add code to get FDC cathode strip pitches and overall x and y offsets for cells (layers) from ccdb.


r17795 | wmcginle | 2015-03-24 15:10:24 -0400 (Tue, 24 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/pi0bcalskim/JEventProcessor_pi0bcalskim.cc

Cleaned up some warning messages


r17798 | marki | 2015-03-24 18:38:59 -0400 (Tue, 24 Mar 2015) | 8 lines Changed paths:

  M /trunk/sim-recon/src/programs/Simulation/HDGeant/control.in
  M /trunk/sim-recon/src/programs/Simulation/HDGeant/controlparams.h
  M /trunk/sim-recon/src/programs/Simulation/HDGeant/controlparams.inc
  M /trunk/sim-recon/src/programs/Simulation/HDGeant/uginit.F

Add FFREAD card to set run number. Here is the comment in control.in:

 If RUNNO card gives a non-negative value, use that value to initialize
 the calibration database and initialize the run number. Run number
 encoded in hddm events will overwrite this run number. Particle gun
 events will use this value.



r17803 | jrsteven | 2015-03-25 13:27:51 -0400 (Wed, 25 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Simulation/HDGeant/hddmInput.c

Use LIH2 target length of 29.9746 cm for bggen vertex position instead of fixed vertex position for the CH2 commissioning target. Ideally this would come from the hdds geometry instead of being hard coded.


r17804 | pmatt | 2015-03-25 14:44:57 -0400 (Wed, 25 Mar 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_BCAL.C

Fix hnamepath for histograms.



r17807 | pmatt | 2015-03-25 17:42:33 -0400 (Wed, 25 Mar 2015) | 5 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.cc
  M /trunk/sim-recon/src/libraries/PID/DEventRFBunch.h
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_BCALReconstruction_p2.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_BCALReconstruction_p3.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_FCALReconstruction_p2.C
  A /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_FCALReconstruction_p3.C

Add histograms for BCAL/FCAL q0 beta vs p. Add these histograms and E / p vs p for q+/- to BCAL & FCAL Create new macros accordingly.



r17845 | nsparks | 2015-03-27 17:20:49 -0400 (Fri, 27 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSHit_factory.cc
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSHit_factory.h

copied over David's code for suppressing messages from multiple threads


r17846 | nsparks | 2015-03-27 17:30:40 -0400 (Fri, 27 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCHit_factory.cc
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCHit_factory.h

calculate the TDC reference time from the timestamp in DCODAROCInfo and F1TDC parameters; when runnumber=0 use hard-coded TDC parms (this will be fixed soon); suppress messages from multiple threads


r17847 | nsparks | 2015-03-27 17:36:29 -0400 (Fri, 27 Mar 2015) | 1 line Changed paths:

  A /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCPair.h
  A /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCPair_factory.cc
  A /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCPair_factory.h
  A /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSPair.h
  A /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSPair_factory.cc
  A /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSPair_factory.h
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/PAIR_SPECTROMETER_init.cc

added factories for coarse and fine PS coincidences


r17858 | staylor | 2015-03-28 17:08:35 -0400 (Sat, 28 Mar 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCSegment_factory.cc
  M /trunk/sim-recon/src/libraries/FDC/DFDCSegment_factory.h

If the radius of the fitted circle from the Riemann fit is less than 1 cm, use a simple circle fit assuming the circle goes through (0,0) to determine the circle parameters.


r17869 | sdobbs | 2015-03-30 18:45:52 -0400 (Mon, 30 Mar 2015) | 2 lines Changed paths:

  M /trunk/sim-recon/src/libraries/DANA/DApplication.cc

Fixed bug in which magnetic field maps specified on the command line weren't always properly overriding the "default" map.


r17875 | mstaib | 2015-04-01 11:30:36 -0400 (Wed, 01 Apr 2015) | 1 line Changed paths:

  A /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/HistogramTools.cc
  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/HistogramTools.h
  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/JEventProcessor_HLDetectorTiming.cc
  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/JEventProcessor_HLDetectorTiming.h

Code used for 3/30 timing calibrations


r17877 | staylor | 2015-04-01 14:45:30 -0400 (Wed, 01 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCGeometry.h

Fix off-by-one error in dealing with strips.


r17889 | davidl | 2015-04-03 10:40:56 -0400 (Fri, 03 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DMagneticFieldMapFineMesh.cc

Add another small informational message to help diagnose problems reading in B-field map.


r17890 | davidl | 2015-04-03 10:47:41 -0400 (Fri, 03 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/DANA/DApplication.cc

Fix printing so that it doesn't say it created a DMagneticFieldMapFineMesh object when it really created a DMagneticFieldMapNoField object.


r17893 | staylor | 2015-04-03 15:29:11 -0400 (Fri, 03 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc

Fix bug in how start counter time is corrected when the hit is in the nose.


r17896 | staylor | 2015-04-03 15:42:33 -0400 (Fri, 03 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate_factory.cc

add fuzzy target position to fit when after linking two FDC-only track candidates.


r17897 | staylor | 2015-04-03 15:47:02 -0400 (Fri, 03 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate_factory_FDCCathodes.cc
  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate_factory_FDCCathodes.h

If all other segment matching methods fail, try Hough transform, but only if the hits in successive segments are close in phi. If one does not apply an angular cut, for events that have many tracks in the FDC, the likelihood of erroneous segment associations is not small.


r17901 | staylor | 2015-04-03 16:49:53 -0400 (Fri, 03 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DGeometry.cc

Set default value for z-position of the center of the target to the nominal 65 cm instead of zero.


r17908 | staylor | 2015-04-03 17:40:38 -0400 (Fri, 03 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DEventRFBunch_factory.cc

Fix what appears to be sign error in how dTime is computed.


r17911 | elton | 2015-04-06 07:46:09 -0400 (Mon, 06 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Simulation/bggen/paw/pi_plot.f
  M /trunk/sim-recon/src/programs/Simulation/bggen/paw/plot_pi0_photons.kumac

update with comments and minor changes


r17912 | pmatt | 2015-04-06 10:39:27 -0400 (Mon, 06 Apr 2015) | 10 lines Changed paths:

  M /trunk/sim-recon/src/SBMS/sbms.py
  M /trunk/sim-recon/src/libraries/DANA/DFactoryGenerator.cc
  M /trunk/sim-recon/src/libraries/DAQ/DCODAROCInfo.h
  M /trunk/sim-recon/src/libraries/DAQ/DF1TDCHit.h
  M /trunk/sim-recon/src/libraries/DAQ/JEventSource_EVIO.cc
  M /trunk/sim-recon/src/libraries/FDC/DFDCHit_factory.cc
  M /trunk/sim-recon/src/libraries/FDC/DFDCHit_factory.h
  M /trunk/sim-recon/src/libraries/FDC/DFDCWireDigiHit.h
  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceHDDM.cc
  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceHDDM.h
  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceREST.cc
  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceREST.h
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCHit_factory.cc
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCHit_factory.h
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCTDCDigiHit.h
  M /trunk/sim-recon/src/libraries/PID/PID_init.cc
  A /trunk/sim-recon/src/libraries/RF
  A /trunk/sim-recon/src/libraries/RF/DRFDigiTime.h
  A /trunk/sim-recon/src/libraries/RF/DRFTDCDigiTime.h
  A /trunk/sim-recon/src/libraries/RF/DRFTime.h
  A /trunk/sim-recon/src/libraries/RF/DRFTime_factory.cc
  A /trunk/sim-recon/src/libraries/RF/DRFTime_factory.h
  A /trunk/sim-recon/src/libraries/RF/RF_init.cc
  A /trunk/sim-recon/src/libraries/RF/SConscript
  M /trunk/sim-recon/src/libraries/SConscript
  M /trunk/sim-recon/src/libraries/START_COUNTER/DSCHit_factory.cc
  M /trunk/sim-recon/src/libraries/START_COUNTER/DSCHit_factory.h
  M /trunk/sim-recon/src/libraries/START_COUNTER/DSCTDCDigiHit.h
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGHHit_factory.cc
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGHHit_factory.h
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGHTDCDigiHit.h
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGMHit_factory.cc
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGMHit_factory.h
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGMTDCDigiHit.h
  M /trunk/sim-recon/src/libraries/TOF/DTOFHit_factory.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTranslationTable.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTranslationTable.h
  M /trunk/sim-recon/src/libraries/TTAB/TTab_init.cc
  M /trunk/sim-recon/src/libraries/include/GlueX.h

Created new RF library, added to build system. Added PS & PSC to DetectorSystem_t. Added MODULE_TYPE to DF1TDCHit objects. Added extraction of RF signals to the translation table code.

Created TTabUtilities class. This class should be used to convert F1TDC "digi" times to ns. If both DCODAROCInfo and DF1TDCConfig objects are available (late 2014 and beyond), the global system clock from the each ROC's TI is used as the reference time, and the F1TDC config info is read in from the datastream (rather than the CCDB) (e.g. "tframe," etc.). If these objects are not available (early 2014 data), then the old method (Beni-cable + CCDB constants) is used.

Modified all hit factories using DF1TDCHit's to use TTabUtilities instead. Note that TTabUtilities must be grabbed for every event (not just in brun) because it gets and saves the DCODAROCInfo objects for each event.



r17915 | pmatt | 2015-04-06 10:49:06 -0400 (Mon, 06 Apr 2015) | 3 lines Changed paths:

  A /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.cc
  A /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.h
  A /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.h

Oops, forgot to svn add the DTTabUtilities.



r17916 | pmatt | 2015-04-06 11:39:03 -0400 (Mon, 06 Apr 2015) | 4 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DEventRFBunch_factory_Combo.cc
  M /trunk/sim-recon/src/libraries/PID/DEventRFBunch_factory.cc

Reverse application of Simon's earlier delta-t-sign fix (his fix was correct, I'm just applying it in a different spot because that's how I think about it). Clean-up rf-bunch selection in combo factory.



r17918 | pmatt | 2015-04-06 14:01:20 -0400 (Mon, 06 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/rawevent/JEventProcessor_rawevent.cc

Don't use digi_scales from each system to get CCDB TDC conversion constants; get from F1TDC instead.



r17919 | pmatt | 2015-04-06 15:45:37 -0400 (Mon, 06 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DEventRFBunch_factory_Combo.cc
  M /trunk/sim-recon/src/libraries/ANALYSIS/DEventRFBunch_factory_Combo.h
  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceHDDM.cc
  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceREST.cc
  M /trunk/sim-recon/src/libraries/PID/DEventRFBunch_factory.cc
  M /trunk/sim-recon/src/libraries/PID/DEventRFBunch_factory.h
  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc
  M /trunk/sim-recon/src/libraries/PID/DParticleID.h

Get rf period from PHOTON_BEAM/RF/rf_period rather than PHOTON_BEAM/rf_frequency. This constant will be deleted soon.



r17920 | pmatt | 2015-04-06 15:53:53 -0400 (Mon, 06 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.h

Fix Beni-cable channel number check.



r17921 | pmatt | 2015-04-06 16:18:37 -0400 (Mon, 06 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.h

If DCODAROCInfo's but no DF1TDCConfig's, use (new) hybrid function.



r17922 | pmatt | 2015-04-06 16:40:37 -0400 (Mon, 06 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/programs/Simulation/HDGeant/hitTag.c

Get rf period from CCDB.



r17923 | pmatt | 2015-04-06 17:09:19 -0400 (Mon, 06 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.h

Fix several instances of data being the wrong type (double when should have been uint64_t, accidentally subtracted uint64_t's instead of int64_t's).



r17926 | pmatt | 2015-04-06 18:39:35 -0400 (Mon, 06 Apr 2015) | 4 lines Changed paths:

  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.h
  A /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.h

I outsmarted myself earlier; wanted to create and modify the object each event rather than new/delete calls, but setting the PERSISTANT flag means that ::evnt() isn't called ... oops. Move constructor routines to factory, just new/delete the thing.



r17932 | nsparks | 2015-04-08 08:18:59 -0400 (Wed, 08 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSHit_factory.cc

skip f250 hits with pedestal or pulse peak equal to zero


r17933 | nsparks | 2015-04-08 08:26:26 -0400 (Wed, 08 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCHit_factory.cc
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCHit_factory.h

fixed array element access error in FillCalibTable(); added ADC_THRESHOLD config. parm., and GetArm() and GetModule() functions; load and use tdc base time offset


r17934 | pmatt | 2015-04-08 10:45:34 -0400 (Wed, 08 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.h
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.cc

DF1TDCConfig objects in the data stream are apparently bad. Insert hard-cut on run number to tell it to use the old scheme (CCDB constants) for tdc_scale, etc. until it is fixed.



r17935 | pmatt | 2015-04-08 18:05:00 -0400 (Wed, 08 Apr 2015) | 4 lines Changed paths:

  M /trunk/sim-recon/src/libraries/RF/DRFTime_factory.cc
  M /trunk/sim-recon/src/libraries/RF/DRFTime_factory.h
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.h
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.cc

Re-arranged DRFTime_factory and DTTabUtilities to expose some functionality to outside callers. Fix handling of FDC F1TDCs when using Beni-cable: The tdc-scale-factor is different for the FDC (low-res) and the Beni-cable (high-res).



r17941 | mstaib | 2015-04-09 11:56:31 -0400 (Thu, 09 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/JEventProcessor_HLDetectorTiming.cc

Fix typo in TAGH TDC times. Change some limits.


r17942 | davidl | 2015-04-09 14:23:44 -0400 (Thu, 09 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackTimeBased.h

Avoid crashes in janaroot due to using double instead of float in AddString call.


r17951 | pmatt | 2015-04-10 16:32:24 -0400 (Fri, 10 Apr 2015) | 5 lines Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCHit_factory.cc
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCHit_factory.cc
  M /trunk/sim-recon/src/libraries/RF/DRFTime_factory.cc
  M /trunk/sim-recon/src/libraries/RF/DRFTime_factory.h
  M /trunk/sim-recon/src/libraries/START_COUNTER/DSCHit_factory.cc
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGHHit_factory.cc
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGMHit_factory.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.h
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.cc
  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.h

In DRFTime factory, use cailbrations constants to set RF time (resolutions, offsets, etc.). This requires updating your copy of the sqlite database.

In DTTabUtilities, added the code for handling TOF tdc shifts (for RF time hooked up to the CAEN). Changed function names of Convert calls so need to update other factories.



r17960 | nsparks | 2015-04-12 10:18:23 -0400 (Sun, 12 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TAGGER/DTAGHHit_factory.cc
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGHHit_factory.h
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGMHit_factory.cc
  M /trunk/sim-recon/src/libraries/TAGGER/DTAGMHit_factory.h

added config. parameter: DELTA_T_ADC_TDC_MAX


r17961 | pmatt | 2015-04-12 15:21:15 -0400 (Sun, 12 Apr 2015) | 4 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.cc
  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Independent.h
  M /trunk/sim-recon/src/libraries/PID/DEventRFBunch.h
  M /trunk/sim-recon/src/libraries/PID/DEventRFBunch_factory.h
  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc
  M /trunk/sim-recon/src/libraries/PID/DParticleID.h
  D /trunk/sim-recon/src/libraries/PID/DRFTime.h
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/DEventProcessor_monitoring_hists.cc
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_BCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_FCAL.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_SC.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_Matching_TOF.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_NumLowLevelObjects_p1.C
  M /trunk/sim-recon/src/programs/Analysis/plugins/monitoring_hists/HistMacro_NumLowLevelObjects_p2.C

Remove PID/DRFTime.h Add monitoring histograms for: matching to individual TOF planes, SC / Track delta-phi vs theta



r17963 | pmatt | 2015-04-13 10:01:37 -0400 (Mon, 13 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Reaction.h
  M /trunk/sim-recon/src/libraries/ANALYSIS/DHistogramActions_Thrown.h

Change paths to DRFTime header.



r17966 | mstaib | 2015-04-13 12:09:03 -0400 (Mon, 13 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/JEventProcessor_HLDetectorTiming.cc

Turn off end of run fits by default


r17967 | zihlmann | 2015-04-13 14:43:03 -0400 (Mon, 13 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCCathodeCluster_factory.cc

check size of the voctor "allHits" before sorting it. this seems to cure the issue of a crash when in multi threaded mode


r17976 | pmatt | 2015-04-13 22:18:06 -0400 (Mon, 13 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceHDDM.h
  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceREST.h
  M /trunk/sim-recon/src/libraries/HDDM/DEventWriterREST.h
  M /trunk/sim-recon/src/libraries/PID/DEventRFBunch_factory_Thrown.h
  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc

More fixes on DRFTime redirect. Fix compiler warnings in DParticleID.



r17982 | staylor | 2015-04-14 10:03:07 -0400 (Tue, 14 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCCathodeCluster_factory.cc

Change where check that size of allHits > 0 is applied.


r17987 | pmatt | 2015-04-14 10:35:32 -0400 (Tue, 14 Apr 2015) | 3 lines Changed paths:

  D /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/SConstruct

Delete SConstruct, which appears to be interfering with the build.



r17992 | pmatt | 2015-04-14 16:02:53 -0400 (Tue, 14 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities.cc

23.4375 is a better 1st-order approximation for the CAEN TDC -> time conversion than 25 ps. Put it in.



r17993 | pmatt | 2015-04-14 16:04:15 -0400 (Tue, 14 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/TOF/DTOFHit_factory.cc

Again, replace 25 ps with 23.4375 ps for CAEN tdc -> time conversion.



r18034 | sdobbs | 2015-04-15 18:48:28 -0400 (Wed, 15 Apr 2015) | 2 lines Changed paths:

  M /trunk/sim-recon/src/programs/Simulation/mcsmear/smear_bcal.cc

Fix reading in of encoded BCALSiPMSpectrum objects.


r18055 | mstaib | 2015-04-16 16:42:42 -0400 (Thu, 16 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/JEventProcessor_HLDetectorTiming.cc
  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/JEventProcessor_HLDetectorTiming.h

Add some BCAL per channel histograms including TDC times


r18057 | sdobbs | 2015-04-16 18:10:24 -0400 (Thu, 16 Apr 2015) | 2 lines Changed paths:

  M /trunk/sim-recon/src/programs/Simulation/HDGeant/hitBCal.cc

Fixed off-by-one error in encoding that dropped some histogram entries.


r18060 | nsparks | 2015-04-16 21:12:44 -0400 (Thu, 16 Apr 2015) | 1 line Changed paths:

  A /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSGeometry.cc
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSGeometry.h
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSGeometry_factory.cc
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSGeometry_factory.h
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSHit_factory.cc
  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSHit_factory.h

added DPSGeometry methods for getting the energy limits of each fine PS counter from ccdb; create DPSGeometry object pointers in brun() instead evnt(); use new PSGeometry methods in hit factory to calculate central energy of PS columns


r18078 | sdobbs | 2015-04-17 14:53:12 -0400 (Fri, 17 Apr 2015) | 6 lines Changed paths:

  M /trunk/sim-recon/src/libraries/HDDM/DEventSourceHDDM.cc

Restoring changes from earlier revision:

> Changed coding of BCALSiPMSpectrum spectrum field to store > consecutive 0 values as "X<N>", where <N> is the number of zero's.



r18079 | sdobbs | 2015-04-17 14:53:44 -0400 (Fri, 17 Apr 2015) | 2 lines Changed paths:

  M /trunk/sim-recon/src/libraries/include/particleType.h

Add charmed particles


r18081 | staylor | 2015-04-17 16:01:38 -0400 (Fri, 17 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate.h
  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate_factory_StraightLine.cc
  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate_factory_StraightLine.h

Add pulls vector to DTrackCandidate and fill it in the straight line fitting code.


r18082 | staylor | 2015-04-17 16:03:46 -0400 (Fri, 17 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackWireBased_factory.cc

For straight line tracks, make sure the pulls vector is filled.


r18083 | staylor | 2015-04-17 16:04:36 -0400 (Fri, 17 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackTimeBased_factory.cc

Fill FOM for straight tracks


r18087 | pmatt | 2015-04-17 17:39:30 -0400 (Fri, 17 Apr 2015) | 5 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DBeamPhoton_factory_KinFit.cc
  M /trunk/sim-recon/src/libraries/ANALYSIS/DKinFitConstraints.h
  M /trunk/sim-recon/src/libraries/ANALYSIS/DKinFitParticle.h
  M /trunk/sim-recon/src/libraries/ANALYSIS/DKinFitResults_factory.cc
  M /trunk/sim-recon/src/libraries/ANALYSIS/DKinFitter.cc
  M /trunk/sim-recon/src/libraries/ANALYSIS/DKinFitter.h
  M /trunk/sim-recon/src/libraries/ANALYSIS/DKinFitter_GlueX.cc

Revamp how memory/objects for kinfit classes is handled. This fixes several bugs in how these objects were used between fits. Also, fix detection of whether kinematic fit results will be unique or exactly the same as a previous fit. No longer clone covariance matrices each time a particle is cloned; only clone at the end of the fit, when a new covariance matrix is set. Recycle memory that was acquired (cloned objects) when sorting constraints.



r18090 | pmatt | 2015-04-19 14:36:13 -0400 (Sun, 19 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/ANALYSIS/DKinFitter.cc

Fix bug: was looping over one vector but accessing another.



r18091 | pmatt | 2015-04-19 19:46:21 -0400 (Sun, 19 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/trackeff_missing/DCustomAction_TrackingEfficiency.cc
  M /trunk/sim-recon/src/programs/Utilities/plugins/trackeff_missing/DCustomAction_TrackingEfficiency.h

Add histograms for track / hit matching. Hard-code target length since geometry is bad for commissioning data.



r18103 | pmatt | 2015-04-20 11:32:49 -0400 (Mon, 20 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/trackeff_missing/DCustomAction_TrackingEfficiency.cc

Delta-phi rollover in degrees.



r18107 | mstaib | 2015-04-20 12:07:02 -0400 (Mon, 20 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/JEventProcessor_HLDetectorTiming.cc

Change index for BCAL TDC times


r18118 | staylor | 2015-04-21 10:46:41 -0400 (Tue, 21 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DGeometry.cc
  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DGeometry.h

Add routine to get start counter geometry from XML.


r18119 | staylor | 2015-04-21 10:49:23 -0400 (Tue, 21 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PID/DParticleID.cc
  M /trunk/sim-recon/src/libraries/PID/DParticleID.h

Use new routine in DGeometry to get start counter geometry. Remove old start counter tracking matching method that started with an intersection with a cylinder.


r18122 | staylor | 2015-04-21 16:49:23 -0400 (Tue, 21 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCPseudo_factory.cc
  M /trunk/sim-recon/src/libraries/FDC/DFDCPseudo_factory.h

Use pulse peak for determining position uusing cathode strips but use pulse integral for dE


r18124 | staylor | 2015-04-21 17:19:15 -0400 (Tue, 21 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/HDGEOMETRY/DGeometry.h

Add a description after the GetStartCounterGeom declaration.


r18130 | nsparks | 2015-04-22 08:15:30 -0400 (Wed, 22 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/PAIR_SPECTROMETER/DPSCPair_factory.cc

require each hit in a PSC pair to have a fADC hit as well as a TDC hit


r18138 | staylor | 2015-04-22 17:39:07 -0400 (Wed, 22 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate_factory_StraightLine.cc

Tweak some parameters to try to improve performance.


r18150 | mstaib | 2015-04-24 10:21:09 -0400 (Fri, 24 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/BCAL/DBCALTDCHit_factory.cc

Code was grabbing the ADC base time offset from the CCDB instead of the TDC.


r18153 | staylor | 2015-04-24 18:00:36 -0400 (Fri, 24 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCPseudo_factory.cc
  M /trunk/sim-recon/src/libraries/FDC/DFDCPseudo_factory.h

Get parameters for measurement uncertainty for position along the wire from ccdb and store this in ds.


r18154 | staylor | 2015-04-24 18:03:53 -0400 (Fri, 24 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackFitterKalmanSIMD.cc
  M /trunk/sim-recon/src/libraries/TRACKING/DTrackFitterKalmanSIMD.h
  M /trunk/sim-recon/src/libraries/TRACKING/DTrackFitterKalmanSIMD_ALT1.cc

Get variance for position along the wire from the DFDCPseudo object instead of recomputing this for each FDC hit for each iteration. Remove some unnecessary scaling of the errors.


r18155 | staylor | 2015-04-24 18:04:59 -0400 (Fri, 24 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/CDC/DCDCTrackHit.h

Add dE to printout


r18158 | staylor | 2015-04-25 16:24:59 -0400 (Sat, 25 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate_factory_StraightLine.cc
  M /trunk/sim-recon/src/libraries/TRACKING/DTrackCandidate_factory_StraightLine.h

Add pulls info for FDC tracks


r18161 | davidl | 2015-04-26 09:13:14 -0400 (Sun, 26 Apr 2015) | 1 line Changed paths:

  A /trunk/sim-recon/src/programs/Utilities/plugins/run_summary/SConscript
  D /trunk/sim-recon/src/programs/Utilities/plugins/run_summary/SConstruct

Replace Sconstruct with SConcript so this can be built with global build system.


r18163 | davidl | 2015-04-26 09:59:01 -0400 (Sun, 26 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/hddm/hddm-cpp.cpp

Cleanup to avoid compiler warnings on lorentz.jlab.org (RHEL7)


r18164 | davidl | 2015-04-26 10:15:21 -0400 (Sun, 26 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Simulation/HDGeant/hitFTOF.c

Cleanup to avoid compiler warnings on lorentz.jlab.org (RHEL7)


r18165 | mstaib | 2015-04-26 17:53:54 -0400 (Sun, 26 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/programs/Utilities/plugins/HLDetectorTiming/JEventProcessor_HLDetectorTiming.cc
Change BCAL Histogram range

r18178 | mstaib | 2015-04-27 12:03:57 -0400 (Mon, 27 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/BCAL/DBCALTDCHit_factory.cc
  M /trunk/sim-recon/src/libraries/BCAL/DBCALTDCHit_factory.h

Use TTABUtilities to calculate TDC time in ns. Change time calculation to match Low-level calibration constants for BCAL. It was multiplying the offsets by t_scale.


r18198 | staylor | 2015-04-28 15:40:14 -0400 (Tue, 28 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/FDC/DFDCHit_factory.cc

Set pulse_height for wires


r18199 | jrsteven | 2015-04-28 15:43:35 -0400 (Tue, 28 Apr 2015) | 1 line Changed paths:

  M /trunk/sim-recon/src/libraries/TTAB/DTTabUtilities_factory.cc

per David's e-mail change run number range to use CCDB for DAQ configuration parameters to 2965, since at least some were corrupted between 2651-2695


r18203 | jonesrt | 2015-04-28 23:12:56 -0400 (Tue, 28 Apr 2015) | 9 lines Changed paths:

  M /trunk/sim-recon/src/programs/Simulation/HDGeant/calibDB.cc
  M /trunk/sim-recon/src/programs/Simulation/HDGeant/gukine.F
  M /trunk/sim-recon/src/programs/Simulation/HDGeant/hitTag.c
  M /trunk/sim-recon/src/programs/Simulation/HDGeant/settofg.F
  M /trunk/sim-recon/src/programs/Simulation/HDGeant/uginit.F
  • settofg.F, hitTag.c, calibDB.cc [rtj]
  - add fortran-callable hook to GetCalib function in calibDB.cc
  - use fortran-callable GetCalib in settofg to get rf bucket spacing
    for a given run number from the ccdb instead of hard-wiring it in the code
  - get the same information about the rf bucket spacing from ccdb
    for use in hitTag.c as well
  • uginit.F, gukine.F [rtj]
  - minor adjustments

r18204 | pmatt | 2015-04-29 12:03:02 -0400 (Wed, 29 Apr 2015) | 3 lines Changed paths:

  M /trunk/sim-recon/src/libraries/RF/DRFTime_factory.cc

Delete the hard-coded line of 2.004 ns period now that the CCDB is correct.